[system] Support CSS grey color in sx
#34548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 I am opposed to displaying warnings. It should work first with native For me, showing warnings might not be a good experience since using |
|
@siriwatknp Adjusted to just use |
siriwatknp
reviewed
Oct 5, 2022
siriwatknp
changed the title
"grey" is used for color prop in sxgrey color in sx
siriwatknp
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
👍 Thanks for your contribution! cc @mnajdova for another review because my suggestion changes the initial solution.
siriwatknp
added
package: system
mnajdova
approved these changes
Oct 12, 2022
mnajdova
changed the title
grey color in sxgrey color in sx
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
|
This introduces an unpleasant performance cost, all colors that go through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
greyis no more recognized as color with the sx prop #31203Changes
When
"grey"is used as the value for a color prop insx, a warning will now be printed to the console explaining the issue and a number of potential remedies.Resolves #31203