Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy] Transitions on sliders and switches disabled for no clear reason #38415

Closed
2 tasks done
BSoDium opened this issue Aug 10, 2023 · 4 comments
Closed
2 tasks done

[joy] Transitions on sliders and switches disabled for no clear reason #38415

BSoDium opened this issue Aug 10, 2023 · 4 comments
Assignees
Labels
component: slider This is the name of the generic UI component, not the React module! component: transitions This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature package: joy-ui Specific to @mui/joy

Comments

@BSoDium
Copy link

BSoDium commented Aug 10, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example:
https://amaze.me.bsodium.fr/

Steps:

  1. Click on either the switch or the slider component
  2. Observe
  3. This seems to happen pretty erratically, which is why I was lead to believe that it was linked to my browser or power settings, but upon further inspection it appears that Joy UI simply does not add any transitions to the afore-mentioned components, which is very peculiar and frustrating.

Current behavior 😯

Neither of these components have transitions on some of my deployed websites, and on some others everything works as expected: https://randomite.bsodium.fr/

Expected behavior 🤔

A deterministic behaviour would be nice (not saying this is MUI's fault but it's a bit infuriating as I have no idea where to start)

Context 🔦

I'd just like these animations to work all the time, so I don't have to implement them myself

Your environment 🌎

npx @mui/envinfo

I used chrome, edge and firefox for my tests

System:
    OS: Windows 10 10.0.22631
  Binaries:
    Node: 20.5.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 9.8.0 - ~\Code\GitLab\frontend\node_modules\.bin\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.22621.2129.0), Chromium (115.0.1901.200)
  npmPackages:
    @emotion/react: ^11.11.1 => 11.11.1
    @emotion/styled: ^11.11.0 => 11.11.0
    @mui/base:  5.0.0-beta.6
    @mui/core-downloads-tracker:  5.14.4
    @mui/joy: 5.0.0-alpha.86 => 5.0.0-alpha.86
    @mui/private-theming:  5.14.4
    @mui/styled-engine:  5.13.2
    @mui/system:  5.14.4
    @mui/types:  7.2.4
    @mui/utils:  5.14.4
    @types/react: ^18.2.14 => 18.2.14
    react: ^18.0.0 => 18.2.0
    react-dom: ^18.0.0 => 18.2.0
    typescript: ^5.1.6 => 5.1.6
@BSoDium BSoDium added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 10, 2023
@zannager zannager added component: slider This is the name of the generic UI component, not the React module! component: transitions This is the name of the generic UI component, not the React module! labels Aug 11, 2023
@michaldudak michaldudak added the package: joy-ui Specific to @mui/joy label Aug 11, 2023
@michaldudak michaldudak changed the title Transitions on sliders and switches disabled for no clear reason [joy] Transitions on sliders and switches disabled for no clear reason Aug 11, 2023
@siriwatknp
Copy link
Member

siriwatknp commented Aug 11, 2023

@BSoDium Thanks for the feedback! Joy UI will need to have default transitions for sure, we are in the process of finding the right one cc @zanivan .

In meanwhile, I think we can add docs to components on how to add transition/theme.

By the way, your website looks great 👍.

@siriwatknp siriwatknp added enhancement This is not a bug, nor a new feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 11, 2023
@BSoDium
Copy link
Author

BSoDium commented Aug 13, 2023

Thank you, but why are there some default transitions on certain deployments that use Joy-UI only? Were these removed in a later release or something?

Also, thank you!

@cryptoAlgorithm
Copy link

I suspect this is the case. One of my older projects, which uses Joy UI, has what appears to be default transitions on the elements. However it seems like from beta-1 onwards there are no transitions entirely.

I haven't experimented to find which version exactly the transitions were removed, but a quick search on PRs didn't turn up anything.

I really hope for the animations to return, even the default ones previously present were quite slick ;D

@BSoDium
Copy link
Author

BSoDium commented Sep 9, 2023

I agree, seems like the current solution to this is to simply reimplement animations from scratch. I'm closing this, so as to not clutter the issue board too much for nothing.

@BSoDium BSoDium closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! component: transitions This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature package: joy-ui Specific to @mui/joy
Projects
None yet
Development

No branches or pull requests

5 participants