Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for disabling some shadows #44291

Open
damisparks opened this issue Nov 1, 2024 · 0 comments
Open

Support for disabling some shadows #44291

damisparks opened this issue Nov 1, 2024 · 0 comments
Assignees
Labels
customization: theme Centered around the theming features status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@damisparks
Copy link

damisparks commented Nov 1, 2024

Summary

Currently, MUI does not allow overriding the Shadows without augmenting the interface.
24 values are quite a lot to choose from. In our use case, we are okay with 3 values.

Since the current Shadows does not allow overrides unless you override the whole list of 24 values.
It would be beneficial to have a way of turning off the values that are not used.

Examples

For example, in the Typography component, we override the variants and disable them via the TypographyPropsVariantOverrides interface.

See the docs Adding & disabling variants. This functionality could be extended to the Shadows.

Motivation

The use case varies across different applications. However, the chances that a design system will have 24 shadow values are almost zero. In our design system, we agreed to have 2 to 3 shadow values.

Hence, being able to disable the ones that are not used is beneficial.

My suggestion is a bit related to this: #28820, but not the same thing.

Search keywords: shadow overrides

@damisparks damisparks added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 1, 2024
@mj12albert mj12albert added the customization: theme Centered around the theming features label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: theme Centered around the theming features status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants