Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Change pnpm order, place second #181

Open
3 of 5 tasks
oliviertassinari opened this issue Jun 20, 2024 · 4 comments · Fixed by mui/material-ui#42712
Open
3 of 5 tasks

[docs] Change pnpm order, place second #181

oliviertassinari opened this issue Jun 20, 2024 · 4 comments · Fixed by mui/material-ui#42712
Assignees
Labels
docs Improvements or additions to the documentation MUI X ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 20, 2024

Summary

pnpm grew to be the second most used dependency management tool: https://2023.stateofjs.com/en-US/libraries/monorepo_tools/ (after npm)

SCR-20240621-bakc

So I believe we should change the order on all the pages of the docs, e.g. https://mui.com/material-ui/getting-started/installation/, https://mui.com/x/react-data-grid/getting-started/#installation.

SCR-20240621-basv

I explored a bit this topic in https://x.com/olivtassinari/status/1789065680370737630.


@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 20, 2024
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jun 20, 2024

@alelthomas maybe a small one, to help discover the codebase and process. This would typically be left to the community otherwise.

@oliviertassinari oliviertassinari added ready to take Help wanted. Guidance available. There is a high chance the change will be accepted and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 20, 2024
ahmadnadeem6236 referenced this issue in ahmadnadeem6236/material-ui Jun 22, 2024
ahmadnadeem6236 referenced this issue in ahmadnadeem6236/material-ui Jun 22, 2024
@rotem227
Copy link

rotem227 commented Jul 6, 2024

@oliviertassinari - this issue is still tagged as "ready to take" so I've created a PR for it.
Should I close it or is it still relevant?

@oliviertassinari
Copy link
Member Author

Should I close it or is it still relevant?

@rotem227 We have an open PR for it mui/material-ui#42712. I think it's about pushing a couple of commits on this PR to get it to the finish line.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 26, 2024

I'm reopening and moving this to mui-public. At this stage, it's a cross MUI docs initiative, cc @samuelsycamore for awareness.

@oliviertassinari oliviertassinari transferred this issue from mui/material-ui Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation MUI X ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants