Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix transformation link in HOW_PIGMENT_CSS_WORKS.md #167

Closed
TakhyunKim opened this issue Jul 7, 2024 · 3 comments · Fixed by #260
Closed

[docs] Fix transformation link in HOW_PIGMENT_CSS_WORKS.md #167

TakhyunKim opened this issue Jul 7, 2024 · 3 comments · Fixed by #260
Assignees
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation support: docs-feedback Feedback from documentation page

Comments

@TakhyunKim
Copy link

TakhyunKim commented Jul 7, 2024

Related page

https://github.com/mui/pigment-css/blob/master/HOW_PIGMENT_CSS_WORKS.md#2-transformation-and-runtime-replacement

Kind of issue

Missing information

Issue description

I was reading the md file linked in the How Pigment CSS Works part of the introduction to Pigment CSS. In the Transformation and runtime replacement section of that md file, the link for transformation is incorrect and I'm getting a 404 Not Found error.

This appears to be an issue with the separation of the Pigment CSS package.
Changing that link to one based on the Pigment CSS repository seems to fix the problem.

I think I can change it to the link below, but I need confirmation.

Context

I'd like to change the incorrect link in that article to remove the inconvenience.
Is it okay if I register a PR if I get the chance?

Search keywords: transformation, docs, md, link

@TakhyunKim TakhyunKim added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Jul 7, 2024
@zannager zannager added the docs Improvements or additions to the documentation label Jul 8, 2024
@mnajdova
Copy link
Member

mnajdova commented Oct 2, 2024

@TakhyunKim sorry for not getting back to you sooner. Feel free to create a PR to fix it, if you haven't already done it by the end of the week I'll fix it myself :)

@mnajdova mnajdova added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 2, 2024
@TakhyunKim
Copy link
Author

@mnajdova Thank you for your reply. I'll PR it after I fix it!

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@TakhyunKim How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation support: docs-feedback Feedback from documentation page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants