Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to opt-out from Cascade Layer #264

Closed
axeleroy opened this issue Oct 7, 2024 · 4 comments
Closed

Option to opt-out from Cascade Layer #264

axeleroy opened this issue Oct 7, 2024 · 4 comments
Assignees
Labels
browser: Safari discussion enhancement This is not a bug, nor a new feature

Comments

@axeleroy
Copy link

axeleroy commented Oct 7, 2024

Summary

I would like an field in PigmentOptions that allows to opt-out from wrapping generated CSS into a Cascade Layer (which was introduced in #226)

Examples

No response

Motivation

I'm building a website using Pigment that requires to support iOS versions as old as 13, which do not support @layer.

Search keywords: layer

@axeleroy axeleroy added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 7, 2024
@zannager zannager added the core Infrastructure work going on behind the scenes label Oct 8, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 12, 2024

The official browser support policy for Pigment CSS is https://mui.com/material-ui/getting-started/supported-platforms/#browser. @layer https://caniuse.com/css-cascade-layers fits into it.

Looking at the relative use https://caniuse.com/css-cascade-layers
SCR-20241013-cckx

I'm not sure we should entertain this further. What's the need to support iOS 13?

@axeleroy
Copy link
Author

Hello,

I had a talk with management, it turns out our decision to support iOS 13 and above was based on outdated visits statistics, I was able to convince them to support iOS 15.4 and above instead.

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 19, 2024

@axeleroy Alright, let's close this issue for now then. By the time Pigment CSS becomes stable, browser support should have improved enough.

Now, it could make sense for https://mui.com/material-ui/getting-started/supported-platforms/#browser to have 3 different tiers of support:

  1. Full support, like today
  2. Best effort support (like the request here, extra work might be needed an bug present)
  3. No support (like IE 11 is under)

If more people request this, I think we could reopen and go with 2.

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@axeleroy How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@github-actions github-actions bot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 19, 2024
@oliviertassinari oliviertassinari added discussion browser: Safari enhancement This is not a bug, nor a new feature and removed core Infrastructure work going on behind the scenes labels Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: Safari discussion enhancement This is not a bug, nor a new feature
Projects
None yet
Development

No branches or pull requests

4 participants