Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Monitor build time in each PR #99

Open
oliviertassinari opened this issue May 26, 2024 · 1 comment
Open

[core] Monitor build time in each PR #99

oliviertassinari opened this issue May 26, 2024 · 1 comment
Assignees
Labels
performance status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented May 26, 2024

Summary

Similar to #78 that is about bundle size, I believe we should eventually monitor the build time cost of Pigment CSS.

Examples

No response

Motivation

See the conversation in https://gitlab.com/gitlab-org/frontend/rfcs/-/issues/107 on adopting Tailwind CSS. Build time is one of the concerns:

How much slower will the build be as comparing from today? (we already have a really slow build due to how we compile JS code in WebPack, would that add to the matter? evaluating the entire codebase is not free)

Search keywords: -

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer performance labels May 26, 2024
@rstarkov
Copy link

The cost of hot starts of eg the Vite dev server is another potential concern, for example it comes up here: mui/material-ui#38137 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants