Image Request: Add an image to include FastAPI

[dudil]

Hello @tedivm - thank you for your great support and work here! Very much appreciated 👏
Would you be able to add another image which is build on your already exist and maintained python-gunicorn-uvicorn?
This will allow in-place replacement for uvicorn-gunicorn-fastapi-docker which is not active maintenance but still being used in various community projects such as full-stack-fastapi-template.

I would be happy to contribute and help if possible 🙏

[tedivm]

The official advice from FastAPI is to not use their own container.

There's a high chance that you don't need this base image or any other similar one, and would be better off by building the image from scratch as described above in: Build a Docker Image for FastAPI.

Believe it or not this is already an in place replacement for that container. The reason is that FastAPI is a very small, source only library, that doesn't actually need anything special compiled.

Take a look at the template you pointed to. The docker file for the backend is as follows:

FROM tiangolo/uvicorn-gunicorn-fastapi:python3.10

WORKDIR /app/

# Install Poetry
RUN curl -sSL https://install.python-poetry.org | POETRY_HOME=/opt/poetry python && \
    cd /usr/local/bin && \
    ln -s /opt/poetry/bin/poetry && \
    poetry config virtualenvs.create false

# Copy poetry.lock* in case it doesn't exist in the repo
COPY ./pyproject.toml ./poetry.lock* /app/

# Allow installing dev dependencies to run tests
ARG INSTALL_DEV=false
RUN bash -c "if [ $INSTALL_DEV == 'true' ] ; then poetry install --no-root ; else poetry install --no-root --only main ; fi"

ENV PYTHONPATH=/app

COPY ./scripts/ /app/

COPY ./alembic.ini /app/

COPY ./prestart.sh /app/

COPY ./tests-start.sh /app/

COPY ./app /app/app

Although it does use the upstream container, it completely discards the FastAPI that was installed with it.

As part of the build process the pyproject.toml file is copied in, and then poetry install is run. Since the docker container hasn't been updated in two years, the requirements.txt has an extremely outdated version of FastAPI (0.88.0), which means that whenever you use that container you're already replacing the built in FastAPI that comes with it.

When I started this project it was because of the lack of multi architecture support in the upstream containers. My first usage of the multi-py/python-gunicorn-uvicorn image was as a drop in replacement for the tiangolo/uvicorn-gunicorn-fastapi, which is why I use the same environment variables and location for the prestart script.

My python project template uses the Multi-Py containers with FastAPI too, so if you want you can generate a project and switch between the two containers to test it out.

[dudil]

💯 Correct @tedivm - excelent point!
Haven't noticed that the layers of dockers are actually very much redundant and seems like even uvicorn installation is not required.
Nevertheless I'll try that out and will suggest the replacement if fits well.
Thank you again for amazing work, this looks awesome!