New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A case to use COPY rather than ADD #12

Open

junaruga opened this issue May 27, 2019 · 0 comments

Member

junaruga commented May 27, 2019

This related to multiarch/qemu-user-static#66 .

seeing

https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy
Although ADD and COPY are functionally similar, generally speaking, COPY is preferred.
...
For other items (files, directories) that do not require ADD’s tar auto-extraction capability, you should always use COPY.

Maybe this code is the case to change from ADD to COPY.
https://github.com/multiarch/centos/blob/master/update.sh#L103

ADD qemu-${qemu_arch}-static /usr/bin

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment