We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In codec.go you append the onion address to the port, which results in 12 bytes, but according to your spec, onion addresses are only 10 bytes (80 bits)
This mismatch results in being unable to decode the onion addresses correctly, since you can't get the port number back.
Should the spec be updated to be 12 bytes, or is prepending a varint to the (addr, port) bytes better?
The text was updated successfully, but these errors were encountered:
Is this still an issue?
cc @david415 @cpacia
Sorry, something went wrong.
it's true that we need to use 12 bytes... but i thought we fixed that a while ago. i guess we missed this bug. good catch!
Merge pull request #19 from multiformats/feature/standardize-readme
08107ee
Standardized README
Merge pull request multiformats#19 from libp2p/fix/close-on-err
5ddf5de
improve correctness of closing connections on failure
No branches or pull requests
In codec.go you append the onion address to the port, which results in 12 bytes, but according to your spec, onion addresses are only 10 bytes (80 bits)
This mismatch results in being unable to decode the onion addresses correctly, since you can't get the port number back.
Should the spec be updated to be 12 bytes, or is prepending a varint to the (addr, port) bytes better?
The text was updated successfully, but these errors were encountered: