Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default styles #315

Open
theamnesic opened this issue Feb 6, 2023 · 5 comments
Open

Default styles #315

theamnesic opened this issue Feb 6, 2023 · 5 comments
Assignees
Milestone

Comments

@theamnesic
Copy link

theamnesic commented Feb 6, 2023

Hi @mundschenk-at !

I just noticed that you add default-styles.css by default in the wp_head since 5.9, even if Include styling for CSS hooks. option is unchecked.

Is it possible not to include it, by a hook or in plugin settings?

Thanks!

@mundschenk-at
Copy link
Owner

I am not sure what you mean? default-styles.css is only used to load the default styles option if you reset your settings.

The only stylesheet logic in the plugin adds an inline style (and not default-styles.css directly) when enabling the `Include styling for CSS hooks." option. That's been unchanged since 2019.

@theamnesic
Copy link
Author

theamnesic commented Feb 7, 2023

Sorry, I wanted to say the content of default-styles.css.
So I think It's a bug.

My settings :

Capture d’écran 2023-02-07 à 11 04 51

But, the inline default-styles.css content in my header :

Capture d’écran 2023-02-07 à 11 05 04

Clearing the cache doesn't change anything.

Maybe since this one, line 251?


WordPress : 6.1.1
wp-Typography : 5.9.1
PHP : 8.0.8

@mundschenk-at
Copy link
Owner

mundschenk-at commented May 7, 2023

Sorry for not getting back to this earlier, do you still have this problem?

I just re-read the line you pointed out and indeed I accidentally removed the guard condition *oops*

@mundschenk-at mundschenk-at self-assigned this May 7, 2023
@mundschenk-at mundschenk-at added this to the 5.9.2 milestone May 7, 2023
@theamnesic
Copy link
Author

Hi @mundschenk-at

Do you have any idea of the 5.9.2 release date?

Thanks!

@mundschenk-at
Copy link
Owner

Really soon now (sorry, I got sidetracked last year). I am currently updating the underlying PHP-Typography package, so that there will be some additional typographic improvements (well, bug fixes mostly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants