Params.sine_range_percent is relative number, not percentage

[froemschied]

MurthyLab_FlySongSegmenter/src/FetchParams.m

Line 53 in c3a5d58

Params.sine_range_percent = 2; % tolerance to merge harmonically-related frequencies

Naming and default value (sine_range_percent = 2) of Params.sine_range_percent suggest it can take values 0-100, but in SineSegmenter.m it is used as a relative number (range 0-1). Using the default parameter will result in matchesAny=true (SineSegmenter.m, line 103) for all cases, such that the segmenter doesn't actually check for harmonics.

Possible solution:

1. add a check for parameter range to segmentSong.m (after line 16) and enforce range 0-1
2. rename parameter e.g. to Params.sine_range_relative

[postpop]

Thanks for raising the issue and sorry about the late reply.
Naming was inherited from the original version of FSS and is indeed misleading.

Renaming the parameter to Params.sine_range_relative would probably best. This may break older custom parameter files but afaik people in the lab only changed pulse parameters, not the sine parameters.

Can you push that fix or make a pull request? Thanks!