Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excluding std<0 regions #1

Open
themiyan opened this issue Sep 7, 2022 · 0 comments
Open

excluding std<0 regions #1

themiyan opened this issue Sep 7, 2022 · 0 comments

Comments

@themiyan
Copy link

themiyan commented Sep 7, 2022

In find_excluded_lbrange, minwave=3 input cannot be passed through as keyword in fit_spec.

So when there are masked values but not consecutive, i.e. std<=0, find_excluded_lbrange function is triggered. But the minwave determined that lines are not needed to be masked. So an empty array [] is returned.
So in linelist.py`` if exlbrange is not None is False, thus an empty array is passed on to for exlb in exlbs: triggering an error.

A quick fix is to add:

  if excluded_lbrange is not None:
       if len(excluded_lbrange)==0: excluded_lbrange = None

after line 609 in line_fitting.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant