Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this be simplified to one autoloader? #5

Open
salcode opened this issue Nov 1, 2019 · 0 comments
Open

Can this be simplified to one autoloader? #5

salcode opened this issue Nov 1, 2019 · 0 comments

Comments

@salcode
Copy link

salcode commented Nov 1, 2019

First, let me just say this is a cool project. I always enjoy your perspective on OOP, in particular in relation to WordPress.

In regards to this issue specifically, in basic-scaffold.php we attempt to use the Composer auto-loader and fall back to a bundled auto-loader if Composer is not present.

Having two autoloaders seems like extra complexity.

If we're going to have the Infrastructure\Autoloader anyway, perhaps we could use that (and remove Composer autoloading support).

Alternatively, Composer usage could be required and the Infrastructure\Autoloader could be removed.

The particular scenario I'm most concerned about is if a bug is introduced into one of the auto-loaders it could be very difficult to detect if someone's particular setup is using the other auto-loader.

Thanks as always for sharing your work with the community. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant