From 052e096cc9ba2c655f3849303fd0f480826ccb2b Mon Sep 17 00:00:00 2001 From: Aaron Hurt Date: Tue, 3 Jul 2018 14:12:06 -0500 Subject: [PATCH] correct logic around secure s3 parameter - fixes #43 --- common/s3util.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/common/s3util.go b/common/s3util.go index ef7a6d8..84138e2 100644 --- a/common/s3util.go +++ b/common/s3util.go @@ -108,8 +108,11 @@ func parseS3URI(s3uri string) (*s3Info, error) { if secure, err = strconv.ParseBool(temps); err != nil { return nil, err } - // update config - info.awsConfig.DisableSSL = aws.Bool(secure) + // update config to disable SSL if secure is false + // see #43 - this was a terrible name for this paramater + if secure == false { + info.awsConfig.DisableSSL = aws.Bool(true) + } } //check for pathstyle override