Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug of settings.modules.cloud_replay.never_expire in ygopro-server.coffee #25

Open
IMJoyJ opened this issue Jan 20, 2020 · 0 comments
Open

A bug of settings.modules.cloud_replay.never_expire in ygopro-server.coffee #25

IMJoyJ opened this issue Jan 20, 2020 · 0 comments

Comments

@IMJoyJ
Copy link

IMJoyJ commented Jan 20, 2020 •
edited
Loading

Position:
ygopro-server.coffee#L1574

Code:
redisdb.expire("replay:"+replay.replay_id, 60*60*48)

Explanation:
Didn't judge settings.modules.cloud_replay.never_expire here, which lead to the deletion of a cloud replay after its playing, even settings.modules.cloud_replay.never_expire is set to true.

Correction method:
Add "if settings.modules.cloud_replay.never_expire" and it would be okay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IMJoyJ