Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings building jones-ndb with node 6.9.1 #41

Open
jdduncan opened this issue Nov 17, 2016 · 2 comments
Open

Deprecation warnings building jones-ndb with node 6.9.1 #41

jdduncan opened this issue Nov 17, 2016 · 2 comments

Comments

@jdduncan
Copy link
Contributor

../impl/include/common/JsWrapper.h: In constructor ‘Envelope::Envelope(const char*)’:
../impl/include/common/JsWrapper.h:173:55: warning: ‘static v8::Localv8::ObjectTemplate v8::ObjectTemplate::New()’ is deprecated (declared at /Users/jdd/.node-gyp/6.9.1/include/node/v8.h:4664): Use isolate version [-Wdeprecated-declarations]
Local proto = ObjectTemplate::New();

jdduncan added a commit that referenced this issue Nov 20, 2016
ObjectTemplate::New() without isolate is deprecated.
Bump jones-ndb version number to 1.0.7
@jdduncan
Copy link
Contributor Author

jdduncan commented Dec 2, 2016

Here's another:

../impl/src/ndb/TransactionImpl_wrapper.cpp:65:3: note: in expansion of macro ‘DEFINE_JS_INT’
DEFINE_JS_INT(target, "Started", NdbTransaction::Started);
^
../impl/include/common/js_wrapper_macros.h:87:68: warning: ‘bool v8::Object::ForceSet(v8::Localv8::Value, v8::Localv8::Value, v8::PropertyAttribute)’ is deprecated (declared at /Users/jdd/.node-gyp/6.9.1/include/node/v8.h:2694): Use CreateDataProperty / DefineOwnProperty [-Wdeprecated-declarations]
static_cast(ReadOnly|DontDelete))
^

@jdduncan
Copy link
Contributor Author

jdduncan commented Dec 7, 2016

And another:

CXX(target) Release/obj.target/ndb_adapter/impl/src/common/async_common.o
../impl/src/common/async_common.cpp:55:16: warning: 'TryCatch' is deprecated [-Wdeprecated-declarations]
v8::TryCatch try_catch;
^
/Users/clr/.node-gyp/6.9.1/include/node/v8.h:6771:40: note: 'TryCatch' has been explicitly marked deprecated here
V8_DEPRECATED("Use isolate version", TryCatch());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant