Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong documentation for use_aggressive_host_checking #152

Open
nook24 opened this issue Feb 6, 2023 · 1 comment
Open

Wrong documentation for use_aggressive_host_checking #152

nook24 opened this issue Feb 6, 2023 · 1 comment

Comments

@nook24
Copy link
Member

nook24 commented Feb 6, 2023

At least for me, it looks like that the documentation of use_aggressive_host_checking is a lie.
From what I learned in naemon/naemon-core#278 this option just swaps the return codes so that a plugin designed for service checks can also be used for host checks.

I scraped real quick through the code and it is just used in one `if``:
https://github.com/naemon/naemon-core/blob/492b8f81af4f57aba69c154881730b5843835647/src/naemon/checks_host.c#L507-L508

The documentation is talking about performance impacts and other things that just looks total wrong to me.
https://www.naemon.io/documentation/usersguide/tuning.html#avoid_aggressive_host_checking
https://www.naemon.io/documentation/usersguide/configmain.html#use_agressive_host_checking

If you guys agree, I will send a pull request to fix this.

@sni
Copy link
Contributor

sni commented Feb 20, 2023

Sure, please send a PR to clarify this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants