Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download on Firefox 97.0 creates a file that says "Invalid Request" #417

Open
DrMcCoy opened this issue Feb 12, 2022 · 6 comments
Open

Download on Firefox 97.0 creates a file that says "Invalid Request" #417

DrMcCoy opened this issue Feb 12, 2022 · 6 comments

Comments

@DrMcCoy
Copy link

DrMcCoy commented Feb 12, 2022

When pressing Ctrl+S on a processed image on Firefox 97.0 (on Gentoo Linux), the result is an image that says "Invalid Request", as if the produced file wasn't grabbed but instead a new request has been started.

It used to work in the past, with older Firefox versions, so it could be related to changes in Firefox.

@qujohn

This comment was marked as off-topic.

@1374363910

This comment was marked as off-topic.

@nagadomi
Copy link
Owner

For a long time, I believe this behavior in Firefox is a bug.

  1. Firefox will try to re-fetch the image data with a GET Request before saving it.
  2. However, the output image of waifu2x is an image data generated by a POST Request with Parameters, so it is impossible to fetch it with a GET Request.

I think this behavior is completely wrong and cannot be fixed by the user.

Also, the download button should work.

@DrMcCoy
Copy link
Author

DrMcCoy commented Feb 13, 2022

Also, the download button should work.

...Huh. You know, I just utterly missed that button. You're right, the button does work.

@iairu
Copy link

iairu commented Sep 18, 2023

Excuse me, I appreciate the work you do on the waifu2x project, but just wanted to ask what is the point of the Download button instead of simply having the Convert button, as the Download button doesn't do anything and Convert can simply be used to download the image right afterwards. Thank you.

@nagadomi
Copy link
Owner

nagadomi commented Sep 18, 2023

Clicking the Download button will automatically download the result image.
The image is automatically downloaded to the web browser's Download Folder without the Save As dialog box appearing.

In some browsers(Firefox or Mobile's browser), Save As feature does not work. That's why there is the download button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants