Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'methodId' field to NormalTx structure #82

Open
tergrif opened this issue Sep 29, 2023 · 1 comment
Open

Add 'methodId' field to NormalTx structure #82

tergrif opened this issue Sep 29, 2023 · 1 comment

Comments

@tergrif
Copy link

tergrif commented Sep 29, 2023

Etherscan API Normal Transfers json response contains also the "methodId" field
(https://docs.etherscan.io/api-endpoints/accounts#response-7)
,which is missing in NormalTx struct. I have added it in code (locally) and it works,but I guess it needs to be formal (if you want to,of course),but I don't understand too much the mechanics of pull requests and merge approvals here

@nanmu42
Copy link
Owner

nanmu42 commented Sep 30, 2023

Hi,

Sure, contributions on missing fields are always welcome!
To create a pull request, you may refer to the guide https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
If it's not feasible, I can take over the editing effort during my free time.

Thanks for the hands-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants