Skip to content
This repository has been archived by the owner on Sep 17, 2019. It is now read-only.

Enhance get_arp_table and get_mac_address_table with filtering arguments #217

Open
kbirkeland opened this issue Mar 1, 2017 · 6 comments

Comments

@kbirkeland
Copy link

I have to deal with some rather large ARP tables (>20k), so it would be nice to have some filtering built into the API.

I propose the following arguments for get_arp_table:

  • ip
  • mac
  • interface

and the following arguments for get_mac_address_table:

  • mac
  • interface
  • vlan
@mirceaulinic
Copy link
Member

I am going to approve this request, it makes sense to me. Let's see what @dbarrosop and @ktbyers think about that as well.

@ktbyers
Copy link
Contributor

ktbyers commented Mar 1, 2017

Yes, I think this is a good idea.

@dbarrosop
Copy link
Member

+1

This was referenced Mar 17, 2017
@mirceaulinic
Copy link
Member

Hi @kbirkeland - this API change is approved. I have created the issues for each driver.
As any API change, we must synchronise all drivers and apply the changed concomitantly. Would you be able to help with this?

Thanks!

@kbirkeland
Copy link
Author

Yeah, I can help with this, but I don't have access to a VM for all the driver types. What's the best course of action for those? Just raise NotImplementedError?

@mirceaulinic
Copy link
Member

Hi @kbirkeland - no problem about the platforms you don't have, please contribute as much as you are able to. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants