Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF: ipnfw ipn_lookupOvrd arguments reversed #9

Open
iondev33 opened this issue Dec 21, 2023 · 0 comments
Open

SF: ipnfw ipn_lookupOvrd arguments reversed #9

iondev33 opened this issue Dec 21, 2023 · 0 comments
Assignees
Labels
Source Forge - bug bug report migrated from SF
Milestone

Comments

@iondev33
Copy link
Collaborator

in bpv7/ipn/ipnfw.c inside the applyRoutingOverride, bindOverride, and main functions, the arguments in the call to ipn_lookupOvrd are not in the the correct order. Argument list SHOULD be dataLabel, destNodeNbr, srcNodeNum, addr, rather than what is currently being used (dataLabel, srcNodeNbr, destNodeNbr, addr).

This bug results in routing overrides not being properly applied. If there are ipn override tests passing, it's likely because the source and destination are also swapped in the ipnadmin configurations.

The easiest fix would just be to use the correct order of arguments. A better (in my opinion) but more time consuming fix would be to make IPN overrides universally have the order dataLabel, srcNodeNbr, destNodeNbr as that seems less likely to produce bugs like this in the future. May not be worth the effort though.

-John

@iondev33 iondev33 added the Source Forge - bug bug report migrated from SF label Dec 21, 2023
@iondev33 iondev33 added this to the ION 4.1.4 milestone Dec 21, 2023
@iondev33 iondev33 self-assigned this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source Forge - bug bug report migrated from SF
Projects
None yet
Development

No branches or pull requests

1 participant