Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit CF for cyclomatic complexity compliance #369

Open
dmknutsen opened this issue Feb 28, 2023 · 3 comments
Open

Audit CF for cyclomatic complexity compliance #369

dmknutsen opened this issue Feb 28, 2023 · 3 comments
Milestone

Comments

@dmknutsen
Copy link
Contributor

Checklist (Please check before submitting)

[x ] I reviewed the [Contributing Guide](https://github.com/nasa/FM/blob/main/CONTRIBUTING.md).
[x ] I reviewed the [README file](https://github.com/nasa/FM/blob/main/README.md) to see if the feature is in the major future work.
[x ] I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
NASA guidelines in NPR 7150.2D recommends maintaining a cyclomatic complexity (cc) in software, in particular flight software of 15 or less.

cf_cmd.c:CF_CmdWriteQueue (cc of 18) and cf_cfdp_r.c:CF_CFDP_R_Tick (cc of 17) unnecessarily violate the recommendation of a cyclomatic complexity of 15 or less.

Describe the solution you'd like
Audit cf_cmd.c:CF_CmdWriteQueue and cf_cfdp_r.c:CF_CFDP_R_Tick to see if functions would benefit from simplification such that they comply with NPR 7150.2D recommendation.

Requester Info
Dan Knutsen

@dmknutsen dmknutsen added this to the Equuleus milestone Apr 5, 2023
@chillfig
Copy link
Contributor

Will Not Fix. This is the desired implementation at this time. In this case, it would not be possible to re-write while maintaining backwards compatibility and would require re-write of the unit/functional/coverage tests.

@chillfig chillfig closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
@skliper
Copy link
Contributor

skliper commented Jun 27, 2023

@dmknutsen @chillfig - we may need this for a project, consider reopening? At minimum it'd be good to be able to trace to an open issue for our documentation.

@dmknutsen
Copy link
Contributor Author

That works for me!

@chillfig chillfig reopened this Jun 27, 2023
@chillfig chillfig removed the wontfix label Jun 27, 2023
@chillfig chillfig removed their assignment Jun 27, 2023
@dmknutsen dmknutsen reopened this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants