Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CF command counters format inconsistent with cFS #382

Open
2 tasks done
thnkslprpt opened this issue May 3, 2023 · 1 comment · Fixed by #383 · May be fixed by #399
Open
2 tasks done

CF command counters format inconsistent with cFS #382

thnkslprpt opened this issue May 3, 2023 · 1 comment · Fixed by #383 · May be fixed by #399

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
CF uses a separate struct (CF_HkCmdCounters_t) to hold the command and error counters. CF is the only app/component of cFS to do this.

Code snips

++CF_AppData.hk.counters.cmd;

Expected behavior
Align CF command counters to the standard cFS implementation.
i.e. CF_AppData.HkPacket.CommandCounter

Reporter Info
Avi Weiss @thnkslprpt

dzbaker added a commit that referenced this issue May 18, 2023
…ter-implementation-with-cfs

Fix #382, Align CF Command Counter implementation to cFS standard
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
chillfig pushed a commit to chillfig/CF that referenced this issue Jul 11, 2023
@chillfig
Copy link
Contributor

chillfig commented Jul 11, 2023

Initial PR solving this issue is reverted by #397. Reopening to be considered for Equuleus-rc2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants