Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static analysis issues JSC 2.1 #444

Closed
2 tasks done
chillfig opened this issue May 23, 2024 · 0 comments · Fixed by #448
Closed
2 tasks done

Static analysis issues JSC 2.1 #444

chillfig opened this issue May 23, 2024 · 0 comments · Fixed by #448
Labels
bug

Comments

@chillfig
Copy link
Contributor

chillfig commented May 23, 2024 •
edited
Loading

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Handful of static analysis issues. This report records the findings from the static analysis to facilitate their tracking.

Source Folder Source Filename Source Line Source Object Disposition
Unsafe Functions: (Medium Risk)        
\apps\cf\fsw\src cf_utils.c 199 strlen Will Fix. CF PR #448
Unchecked Return Value on Function / Truncation of Data Risk        
\apps\cf\fsw\src cf_utils.c 186 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output.
\apps\cf\fsw\src cf_utils.c 191 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output.
\apps\cf\fsw\src cf_utils.c 195 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output.

To Reproduce
N/A. These issues were communicated by JSC.

Expected behavior
A clear and concise description of what you expected to happen.

Code snips
N/A

System observed on:
N/A

Additional context
N/A

Reporter Info
Imported from JSC 2.1 static analysis
Source Folder Source Filename Source Line Source Object Disposition
Unsafe Functions: (Medium Risk)
\apps\cf\fsw\src cf_utils.c 199 strlen Will Fix. CF PR #448

Unchecked Return Value on Function / Truncation of Data Risk
\apps\cf\fsw\src cf_utils.c 186 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output.
\apps\cf\fsw\src cf_utils.c 191 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output.
\apps\cf\fsw\src cf_utils.c 195 snprintf Will Not Fix. No need to check snprintf return; buffer size is sufficient for the formatted output.
@chillfig chillfig added bug CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 23, 2024
chillfig pushed a commit to chillfig/CF that referenced this issue Jun 6, 2024
Fix nasa#444, Adds JSC 2.1 Static Analysis comments
40db6eb
@chillfig chillfig mentioned this issue Jun 6, 2024
Merged
2 tasks
chillfig pushed a commit to chillfig/CF that referenced this issue Jun 6, 2024
Fix nasa#444, Adds JSC 2.1 Static Analysis comments
ac96459
chillfig pushed a commit to chillfig/CF that referenced this issue Jun 10, 2024
Fix nasa#444, Adds JSC 2.1 Static Analysis comments
b532de9
@chillfig chillfig removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jun 13, 2024
chillfig pushed a commit to chillfig/CF that referenced this issue Jun 18, 2024
Fix nasa#444, Adds JSC 2.1 Static Analysis comments and exposes CF_st…
a7d14e8 
…rnlen

This commit addresses issues flagged during static analysis by:
- Adding JSC 2.1 disposition comments.
- Making CF_strnlen publicly accessible and replacing strlen with it.
chillfig pushed a commit to chillfig/CF that referenced this issue Jun 21, 2024
Fix nasa#444, Adds JSC 2.1 Static Analysis comments and adds OS_strnlen
e6c6266 
This commit addresses issues flagged during static analysis by:
- Adding JSC 2.1 disposition comments.
- Replacing strlen with OS_strnlen.
chillfig pushed a commit to chillfig/CF that referenced this issue Jun 27, 2024
Fix nasa#444, Adds JSC 2.1 Static Analysis comments and adds OS_strnlen
a788a3f 
This commit addresses issues flagged during static analysis by:
- Adding JSC 2.1 disposition comments.
- Replacing strlen with OS_strnlen.
dzbaker added a commit that referenced this issue Jul 2, 2024
@dzbaker
Merge pull request #448 from chillfig/SA_jsc2_1
7639e40 
Fix #444, Adds JSC 2.1 Static Analysis comments and exposes CF_strnlen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #444, Adds JSC 2.1 Static Analysis comments and exposes CF_strnlen chillfig/CF
1 participant
@chillfig