-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static analysis issues JSC 2.1 #127
Labels
Comments
chillfig
pushed a commit
to chillfig/DS
that referenced
this issue
Jun 10, 2024
2 tasks
chillfig
pushed a commit
to chillfig/DS
that referenced
this issue
Jun 10, 2024
chillfig
pushed a commit
to chillfig/DS
that referenced
this issue
Jun 13, 2024
… snprintf This commit addresses issues flagged during static analysis by: - Adding JSC 2.1 disposition comments. - Replacing strncpy with snprintf to enhance safety and compliance.
chillfig
pushed a commit
to chillfig/DS
that referenced
this issue
Jun 14, 2024
… snprintf This commit addresses issues flagged during static analysis by: - Adding JSC 2.1 disposition comments. - Replacing strncpy with snprintf to enhance safety and compliance. - Changes DS_TABLE_VERIFY_ERR from 0xFFFFFFFF to -1
chillfig
pushed a commit
to chillfig/DS
that referenced
this issue
Jun 14, 2024
… snprintf This commit addresses issues flagged during static analysis by: - Adding JSC 2.1 disposition comments. - Replacing strncpy with snprintf to enhance safety and compliance. - Changes DS_TABLE_VERIFY_ERR from 0xFFFFFFFF to -1
dzbaker
added a commit
that referenced
this issue
Jun 27, 2024
Fix #127, Adds static analysis comments and replace strncpy with snprintf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist (Please check before submitting)
Describe the bug
Handful of static analysis issues. This report records the findings from the static analysis to facilitate their tracking.
To Reproduce
N/A. These issues were communicated by JSC.
Expected behavior
Need to resolve these. Should resolve and/or disposition the higher ranked ones at minimum.
Code snips
N/A
System observed on:
N/A
Additional context
N/A
Reporter Info
Imported from JSC 2.1 static analysis
Source Folder Source Filename Source Line Source Object Disposition
Integer Overflow
\apps\ds\fsw\src ds_table.c 423 Result Will Fix. DS PR #130
\apps\ds\fsw\src ds_table.c 545 Result Will Fix. DS PR #130
Unsafe Functions
\apps\ds\fsw\src ds_cmds.c 1099 strncpy Will Fix. DS PR #130
\apps\ds\fsw\src ds_file.c 886 strncpy Will Fix. DS PR #130
\apps\ds\fsw\src ds_file.c 1001 strncpy Will Fix. DS PR #130
Off by One
\apps\ds\fsw\src ds_app.c 361 FilterTblFilename Will Fix. DS PR #130
\apps\ds\fsw\src ds_cmds.c 1099 sizeof Will Fix. DS PR #130
\apps\ds\fsw\src ds_file.c 886 sizeof Will Fix. DS PR #130
\apps\ds\fsw\src ds_file.c 1001 sizeof Will Fix. DS PR #130
Buffer Improper Access
\apps\ds\fsw\src ds_app.c 361 FilterTblFilename Will Fix. DS PR #130
The text was updated successfully, but these errors were encountered: