Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent use of CFE_EVS_EventType_Enum_t (and clarify vs mask) #1398

Open
skliper opened this issue Apr 20, 2021 · 2 comments · May be fixed by #2308
Open

Consistent use of CFE_EVS_EventType_Enum_t (and clarify vs mask) #1398

skliper opened this issue Apr 20, 2021 · 2 comments · May be fixed by #2308
Labels
CFS-41 enhancement

Comments

@skliper
Copy link
Contributor

skliper commented Apr 20, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Numerous locations where EventType is declared as uint16, but there's a defined type CFE_EVS_EventType_Enum_t

Describe the solution you'd like
Use CFE_EVS_EventType_Enum_t everywhere

Describe alternatives you've considered
Use uint16 everywhere

Additional context
Code review
#1447 - need to sort out enum vs mask use

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Apr 20, 2021
@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 20, 2021
@skliper
Copy link
Contributor Author

skliper commented Apr 21, 2021

This allows the label to be printed for the value (naming convention), so it makes sense to have this for ENUM but not for general types.

@astrogeco
Copy link
Contributor

CCB:2021-04-21 Discussed

@skliper skliper removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 21, 2021
@skliper skliper mentioned this issue Apr 29, 2021
Open
skliper added a commit to skliper/cFE that referenced this issue May 24, 2021
@skliper
Fix nasa#1398, Consistent use of uint16 for EventID
38f434d
@skliper skliper changed the title CFE_EVS_EventType_Enum_t only used in 1 location, no CFE_EVS_EventID_t type... Consistent use of CFE_EVS_EventType_Enum_t (and clarify vs mask) May 25, 2021
@skliper skliper removed this from the 7.0.0 milestone May 25, 2021
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Apr 26, 2023
@thnkslprpt
Fix nasa#1398, Consistent use of CFE_EVS_EventType_Enum_t for `Even…
c345824 
…tType`
@thnkslprpt thnkslprpt linked a pull request Apr 26, 2023 that will close this issue
Open
2 tasks
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue May 5, 2023
@thnkslprpt
Fix nasa#1398, Consistent use of CFE_EVS_EventType_Enum_t for `Even…
1f73f8b 
…tType`
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Oct 26, 2023
@thnkslprpt
Fix nasa#1398, Consistent use of CFE_EVS_EventType_Enum_t for `Even…
4d60bc3 
…tType`
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Oct 26, 2023
@thnkslprpt
Fix nasa#1398, Consistent use of CFE_EVS_EventType_Enum_t for `Even…
af51f08 
…tType`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-41 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1398, Consistent use of CFE_EVS_EventType_Enum_t for EventType thnkslprpt/cFE
2 participants
@skliper @astrogeco