Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the sass file could use some variable goodness #49

Open
chrisdrackett opened this issue Mar 22, 2012 · 9 comments
Open

the sass file could use some variable goodness #49

chrisdrackett opened this issue Mar 22, 2012 · 9 comments

Comments

@chrisdrackett
Copy link

being sass and all

@nathansmith
Copy link
Owner

What aspects would you like to see variable-ized?

@chrisdrackett
Copy link
Author

I just saw a lot of repeated colors and sizes. Seems if you are going to use sass, might be worth creating maybe a mixin so users can customize the colors/sizes by changing a couple of clear variables

@nathansmith
Copy link
Owner

Yeah, not disagreeing, was just wondering if you had specifics you'd like to see variable-ized. Cool, cool.

@chrisdrackett
Copy link
Author

yeah, sorry ;)

I actually wrote this issue and was planning on doing it myself. Then I decided that formalize has a bit too many default styles for my use, and I've started writing my own "reset" that in theory will be theme-able.

@nathansmith
Copy link
Owner

This might be of interest...

https://gist.github.com/1599212

It removes all styling of form elements, so that they can be built back up again.

@chrisdrackett
Copy link
Author

nice, thanks :)

@chrisvanpatten
Copy link

I'd love to see Formalize variablized too. It would make it easy to deploy customized versions.

@henrijs
Copy link

henrijs commented May 29, 2012

For me main issue is padding of form elements. This line in particular is evil "height: 1.8em;" If I add 3 pixels of padding above and below, by how much should I increase height? (Rethorical question). Sass could calculate that probably.

Also font-family could be as one mixin.

@nathansmith
Copy link
Owner

@henrijs — Sure, that could be automated (made dependent on a variable), but not reliably calculated. I mean, it's going to be contingent on whatever visual effect you're trying to achieve. I settled on 1.8em because that makes textual inputs the same height as a <select> drop-down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants