Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search query to events and menu items #126

Open
Frewacom opened this issue May 7, 2021 · 0 comments
Open

Add search query to events and menu items #126

Frewacom opened this issue May 7, 2021 · 0 comments
Assignees
Labels
api Improvement or changes to the API feature New feature future improvement Improvements to existing code

Comments

@Frewacom
Copy link
Member

Frewacom commented May 7, 2021

You need to be able to search among all menu items/events. Currently, in the app, you can only search among the fetched data. Since the data is paginated, you need to make sure to scroll and load all data before you can make a "good" search. What we should do instead is to add a new query to the existing endpoints that allows us to specify a custom search term.

Example endpoints:

GET /events?page=1&number=10&search=custom%20search%20query

should return a paginated collection of events that matches "custom search query" in the name (and/or description?).

The same goes for the menu items:

GET /menus/1/items?page=1&number=10&search=custom%20search%20query
@Frewacom Frewacom added feature New feature api Improvement or changes to the API improvement Improvements to existing code future labels May 7, 2021
@McFrappe McFrappe self-assigned this May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Improvement or changes to the API feature New feature future improvement Improvements to existing code
Projects
None yet
Development

No branches or pull requests

2 participants