Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change request error code for invalid login attempts #163

Open
Frewacom opened this issue Jun 14, 2021 · 0 comments
Open

Change request error code for invalid login attempts #163

Frewacom opened this issue Jun 14, 2021 · 0 comments
Assignees
@McFrappe
Labels
api Improvement or changes to the API auth Authentication of users improvement Improvements to existing code

Comments

@Frewacom
Copy link
Member

Currently, the returned error code is 400 (Bad request). I think this is a bit strange, especially from a front-end perspective. Using 401 (Unauthorized) or 403 (Forbidden) seems more appropriate.
@Frewacom Frewacom added api Improvement or changes to the API auth Authentication of users improvement Improvements to existing code labels Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@McFrappe McFrappe

Labels
api Improvement or changes to the API auth Authentication of users improvement Improvements to existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Frewacom @McFrappe