Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use users as "individuals" rather than having a separate model #173

Open
Frewacom opened this issue Jul 1, 2021 · 0 comments
Open

Use users as "individuals" rather than having a separate model #173

Frewacom opened this issue Jul 1, 2021 · 0 comments
Assignees
Labels
api Improvement or changes to the API feature New feature improvement Improvements to existing code

Comments

@Frewacom
Copy link
Member

Frewacom commented Jul 1, 2021

Each nation can have a selected few individuals that are important and should be visible on their nation page. Currently, these "individuals" are a separate model that contains much of the same information as the users. My suggestion would be to simply remove the existing individual model (and most of the existing routes) and instead use the already existing user models.

Solution

  • Remove the individuals model
  • Add a new field to the user model that contains a short personal description (this can be changed from their profiles of the admin interface)
  • Add new routes that allows us to add and remove users from a list of selected users. The users in this list will be shown in the nation page
  • Consider limiting the amount of users in the list (e.g. 5-10)
@Frewacom Frewacom added feature New feature api Improvement or changes to the API improvement Improvements to existing code labels Jul 1, 2021
@McFrappe McFrappe self-assigned this Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Improvement or changes to the API feature New feature improvement Improvements to existing code
Projects
None yet
Development

No branches or pull requests

2 participants