Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DATABASE_URL to be provided #8

Open
naude-r opened this issue Oct 31, 2023 · 4 comments · May be fixed by #9
Open

Allow DATABASE_URL to be provided #8

naude-r opened this issue Oct 31, 2023 · 4 comments · May be fixed by #9

Comments

@naude-r
Copy link

naude-r commented Oct 31, 2023

would it be possible to allow an optional DATABASE_URL to be provide? this is mostly to configure jdbc url that differs slightly from the norm, e.g. mssql:
jdbc:sqlserver://localhost:1433;DatabaseName=hive_metastore;

using the existing env variables result in an error:
Underlying cause: com.microsoft.sqlserver.jdbc.SQLServerException : The port number 1433/hive_metastore is not valid.

if DATABASE_URL is specified then the other connection related env can be skipped.
@naude-r naude-r linked a pull request Oct 31, 2023 that will close this issue
Open
@naushadh
Copy link
Owner

Apologies for the very long delay; from your post it's evident you're trying to use MS-SQL with HMS; however, that's may break for more than just the connection url because the image is only configuring the Postgres driver. Got a couple questions for you

  1. Did support an optional DATABASE_URL env variable. #9 make the image work with MS-SQL server?
  2. Are you still interested in seeing this issue resolved?

@naude-r
Copy link
Author

naude-r commented Aug 21, 2024

@naushadh thank you for the response. yes, the PR did solve the issue.

unfortunately we've since moved on to other solutions and do not require this anymore.

@naushadh
Copy link
Owner

Understandable; just for curiosity, do you mind sharing the other solution that you'd moved to?

@naude-r
Copy link
Author

naude-r commented Aug 22, 2024

sure, the client moved to a cloud managed instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support an optional DATABASE_URL env variable. naude-r/hive-metastore
2 participants
@naushadh @naude-r