Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed extends base.html to extends generic/object_edit.html for the create peering template and removed unnecessary rules from .gitignore #79

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Changed extends base.html to extends generic/object_edit.html for the create peering template and removed unnecessary rules from .gitignore #79

wants to merge 3 commits into from

Conversation

briddo
Copy link
Contributor

@briddo briddo commented Jan 31, 2023

Fixes: #77

@briddo
Changed extends base.html to extends generic/object_edit.html for cre…
197a3ab 
…ate peering template and removed unnecessary rules from .gitignore
@snaselj snaselj self-assigned this Apr 3, 2023
glennmatthews
glennmatthews approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me - @snaselj any concerns?

@snaselj
Copy link
Contributor

snaselj commented May 2, 2023

Looks okay to me - @snaselj any concerns?

LGTM @glennmatthews

@mzbroch
Copy link
Contributor

mzbroch commented Apr 4, 2024

@glennmatthews @snaselj Can we close this PR, as we now have peering_add.html using {% extends 'base.html' %} ?

@glennmatthews
Copy link
Contributor

Is there a reason peering_add.html can't or shouldn't inherit from generic/object_create.html instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
type: housekeeping
Projects
No open projects
Nautobot Ecosystem 🌎 - 2.0 Migration
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Legacy template needs to extend generic/object_edit.html
5 participants
@briddo @snaselj @mzbroch @glennmatthews @bryanculver