Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toggle option for Dictionary Unpacking #4

Open
jvanderaa opened this issue Feb 24, 2021 · 2 comments
Open

Add toggle option for Dictionary Unpacking #4

jvanderaa opened this issue Feb 24, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest good first issues status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation
Milestone
v1.1

Comments

@jvanderaa
Copy link
Contributor

jvanderaa commented Feb 24, 2021 •
edited
Loading

Add flag to unpack the pynautobot object into a dictionary. Should default to True to unpack.
@jvanderaa jvanderaa changed the title Issue 4 Add toggle option for Dictionary Unpacking Feb 24, 2021
@jvanderaa jvanderaa added the good first issue Good for newcomers label Feb 24, 2021
@jvanderaa jvanderaa added this to the v1.1 milestone Feb 24, 2021
itdependsnetworks pushed a commit that referenced this issue Feb 24, 2021
@jvanderaa
Merge pull request #4 from networktocode-llc/add_contributing
d34ef8e 
Adds Contributing Guide
@jvanderaa jvanderaa added enhancement New feature or request help wanted Extra attention is needed labels Apr 23, 2021
@pke11y
Copy link
Contributor

pke11y commented Jun 3, 2021

@jvanderaa Is this toggle option on the inventory object?
What is the objective?

@jvanderaa
Copy link
Contributor Author

The objective is that there is currently a pynautobot_dictionary key in the inventory data key by default. This is a "nice to have" at this time that many will probably not want to have in the inventory. The thought is to make a toggle of pynautobot_dictonary_unpack or some other name (since that is long), that would not add the dictionary version to the data returned.

pke11y added a commit to pke11y/nornir-nautobot that referenced this issue Jun 8, 2021
@pke11y
Add toggle for pynautobot dict object and add test coverage nautobot#4
d45c7d1
@jvanderaa jvanderaa added status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation and removed help wanted Extra attention is needed labels Jun 27, 2022
@jvanderaa jvanderaa added the hacktoberfest Hacktoberfest good first issues label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest good first issues status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@jvanderaa @pke11y