Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are Introduced in Z2H Tutorial Before Fixes to struct #1162

Closed
idea404 opened this issue Mar 2, 2022 · 3 comments
Closed

Tests are Introduced in Z2H Tutorial Before Fixes to struct #1162

idea404 opened this issue Mar 2, 2022 · 3 comments

Comments

@idea404
Copy link
Contributor

idea404 commented Mar 2, 2022

Unit tests that make use the Smart Contract's new method are introduced here, while the changes to the Contract struct (adding the required #[init]) are introduced after here.

This complicates the code-along experience of the tutorial as learners would be left debugging for an error the tutorial does not go into. Proposed solution would be to either:

  • Move this change before the unit tests are introduced
  • Work through the bug with the learner/explain in the tutorial
@idea404
Copy link
Contributor Author

idea404 commented Mar 11, 2022

Quoting a dev from the community who ran into this same issue:

I think it would have made more sense to update the Contract functions before building the Unit tests

Conversation can be followed here: https://discord.com/channels/490367152054992913/542945453533036544/951793545927344128

@bucanero
Copy link
Collaborator

For reference, the Crosswords tutorial has been moved to docs.near.org

@bucanero bucanero transferred this issue from near/sdk-docs Aug 25, 2022
@bucanero
Copy link
Collaborator

fixed in #1673

@bucanero bucanero self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Done
Development

No branches or pull requests

2 participants