Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contract to use enums for config instead of struct #964

Open
Tracked by #930
darunrs opened this issue Aug 1, 2024 · 0 comments
Open
Tracked by #930

Update contract to use enums for config instead of struct #964

darunrs opened this issue Aug 1, 2024 · 0 comments

Comments

@darunrs
Copy link
Collaborator

darunrs commented Aug 1, 2024

No description provided.

darunrs added a commit that referenced this issue Aug 1, 2024
We've noticed that it is occasionally possible for the indexer config
returned by the contract to be parseable/null with a success status
code, even though the indexer itself was not in fact deleted. This
triggers the deprovisioning workflow anyway, which currently throws the
Indexer into a repairing state, where it is no longer operating.

This PR updates the contract to retain configuration if the indexer was
deleted. Coordinator will now expect a specific configuration to take
deletion actions, instead of the previous method which left things open
to interpretation.

In the near future, the contract will be migrated (#964) to use an enum
instead of contract format, to avoid wastefully storing things like
code/schema for deleted indexers forever.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant