You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Place 3 (branch in .gitmodules) is most likely a bug. The Github documentation [1] states that this value is only picked up when the --remote option is used for git submodule update, which we do not do. Also, it has to be a branch name and not a hash value. Indeed, the following command fails.
$ LC_ALL=C git submodule update --init --recursive --remote
fatal: Needed a single revision
fatal: Unable to find current origin/bd7fc2c revision in submodule path 'vcpkg'
According to [2], place 2 (buildin-baseline) makes sense if we use versioning in vcpkg.json, i.e., use dependency versions that are either older or newer as the baseline. However, we do not do this, so place 1 (just the committed version under vcpkg) would be simpler. Moreover, if we use a version in 2 that is newer than the version in 1, then vcpkg install fails, e.g.:
$ ./manual-build.sh arm64-osx
Chosen triplet: arm64-osx-nes
ARM64 detected, using system binaries...
Downloading vcpkg-macos...
Error: No version entry for apr at version 1.7.0#7. This may be fixed by updating vcpkg to the latest master via `git pull`.
Available versions:
1.7.0#6
1.7.0#5
1.7.0#4
1.7.0#3
1.7.0#2
1.7.0-1
1.7.0
1.6.5-3
1.6.5-2
1.6.5-1
1.6.5
1.6.3
1.6.2-1
1.6.2
1.5.2
...
Description
Currently, there are three places where the current version of dependencies is updated.
The SHA stored in the git commit that is updated with
git pull
in the submodule folder. This is currently https://github.com/microsoft/vcpkg/tree/daa7215f3d68c2a2f2e18c398cb73dab63cda829 from 2022-02-23. It was last changed in c8b2937.The SHA value stored under
buildin-baseline
in https://github.com/nebulastream/nebulastream-dependencies/blob/master/vcpkg.json. This is currently https://github.com/microsoft/vcpkg/tree/69d5556d0d8c105f75055326cef346546e40e615 from 2021-09-17. This was added in 6529549.A short SHA stored as an entry in
branch
in.gitmodules
. This is currently https://github.com/microsoft/vcpkg/tree/bd7fc2c from 2021-08-19. It was added in 35c7a2b.Place 3 (
branch
in.gitmodules
) is most likely a bug. The Github documentation [1] states that this value is only picked up when the--remote
option is used forgit submodule update
, which we do not do. Also, it has to be a branch name and not a hash value. Indeed, the following command fails.According to [2], place 2 (
buildin-baseline
) makes sense if we use versioning invcpkg.json
, i.e., use dependency versions that are either older or newer as the baseline. However, we do not do this, so place 1 (just the committed version undervcpkg
) would be simpler. Moreover, if we use a version in 2 that is newer than the version in 1, thenvcpkg install
fails, e.g.:[1] https://www.git-scm.com/docs/git-submodule
[2] https://devblogs.microsoft.com/cppblog/take-control-of-your-vcpkg-dependencies-with-versioning-support/
Acceptance criteria
The text was updated successfully, but these errors were encountered: