Possibility for cancelled/aborted stages to leave stray files in pool

[ZNikke]

Considering the abort() function

dcache-endit-provider/src/main/java/org/ndgf/endit/StageTask.java

Line 135 in 71cf6b2

return Files.deleteIfExists(requestFile) && Files.deleteIfExists(errorFile) && Files.deleteIfExists(inFile);

I think it should probably delete the final destination file as well if it exists, since the stage was aborted the pool will have no knowledge of the file if the provider was too quick in placing it there. This of course assumes that abort() isn't used for general cleanup after a successful stage.

It looks to me that there is no check in poll()

dcache-endit-provider/src/main/java/org/ndgf/endit/StageTask.java

Line 105 in 71cf6b2

public Set<Checksum> poll() throws IOException, InterruptedException, EnditException

that checks that the stage is still active before moving a staged file to its final destination, does the dcache nearline spi handle this or should the provider do some additional checks?