Unregister before register capability with same id

[kit494way]

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

When receive multiple client/registerCapbility requests with same id, duplicate completion sources are registered like the issue coc-extensions/coc-omnisharp#53 .

Describe the solution you'd like
A clear and concise description of what you want to happen.

Call feature.unregister(registration.id) before this

coc.nvim/src/language-client/client.ts

Line 4124 in 4e3b7f3

feature.register(this._method2Message.get(registration.method)!, data)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

[chemzqm]

Should be fixed by d9092b7

[kit494way]

It looks like the issue is not fixed.

When language server retry to send a client/registerCapability request, language client receive multiple requests with same registration id.
registerLanguageProvider() method is called whether the request with same id is already handled or not, although the registration is managed by the id.

coc.nvim/src/language-client/client.ts

Lines 1726 to 1727 in 531f5af

	let registration = this.registerLanguageProvider(data.registerOptions)
	this._registrations.set(data.id, { disposable: registration[0], data, provider: registration[1] })

In the situation that requests with same id are received, it may be something wrong with language server, but it is helpful to unregister the provider before register with same id or drop the request.

[Nazeehe]

I am unclear as to if this issue is fixed or not. The issue is closed, but I am seeing from the post above that it might not be?