Data loss caused by header overwrite

[Mubelotix]

Minreq is currently unable to handle headers appearing multiple times in the response.
Only the last value is stored, as it is inserted over the previous values.

minreq/src/response.rs

Line 303 in efbaf75

headers.insert(header, value);

[neonmoe]

Yep, this is planned for 3.0, since it would require changing the Response struct's public API.

[Mubelotix]

Great! I need a quick fix so I will do it myself but it would be great if that could benefit to other users too. I could do a PR. How would you prefer to solve this? Using a custom HeaderMap like reqwest did or using a HashMap<String, Vec<String>>?

[neonmoe]

I haven't given it much thought. Reqwest's solution certainly makes for a clean API, but I fear that would require quite a bit of code, and I'd rather keep minreq as simple as possible. I think a HashMap<String, Vec<String>> would be good if combined with a convenience function for Response, e.g. Response::get_header(key: &str) -> Option<&str>, which would just return the first header, if any.