Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handbook with draft PRs #5

Open
reubano opened this issue May 3, 2020 · 0 comments
Open

Update handbook with draft PRs #5

reubano opened this issue May 3, 2020 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@reubano
Copy link
Member

reubano commented May 3, 2020

I removed it since the new github teams only allows draft PR on public repos. The docs need to be updated to make this distinction.

Original text

When you create a new branch in a project, you should immediately push that branch up to Github and create a Draft Pull Request. This allows co-workers and your boss to make comments on your code while you are writing it.

When you are ready to merge your code into the master branch, you change your Draft PR into a Pull Request (PR).

@reubano reubano added the documentation Improvements or additions to documentation label May 3, 2020
@reubano reubano added this to the med milestone May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants