Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return standardized return values from Animation new, render and interact instead of tuples. #66

Open
doughsay opened this issue Jul 11, 2020 · 1 comment
Labels
discussion Needs discussion refactor Refactoring code or tech debt repayment

Comments

@doughsay
Copy link
Member

new and interact both return {render_in, state} and render returns {render_in, colors, state}. They are so close to being the same, let's see if we can come up with a good refactor here that makes these all a shared struct definition instead of "almost the same" tuples.

@doughsay doughsay added refactor Refactoring code or tech debt repayment discussion Needs discussion labels Jul 11, 2020
@doughsay doughsay mentioned this issue Jul 11, 2020
4 tasks
@doughsay
Copy link
Member Author

We discussed that new should not return render_in, as all animations we can think of will always return 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Needs discussion refactor Refactoring code or tech debt repayment
Projects
None yet
Development

No branches or pull requests

1 participant