New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RGBMatrix.Animation submodules #81

Open

3 of 8 tasks

vanvoljg opened this issue Jul 15, 2020 · 0 comments

Labels

refactor

Member

vanvoljg commented Jul 15, 2020 •

edited

Loading

The animations have multiple places where they need to be touched up.

SolidReactive module has three TODOs, one FIXME, and one Credo-suggested refactor to reduce nesting depth:

Nesting depth refactor (lib/rgb_matrix/animation/solid_reactive.ex#L72-L87)
FIXME: leaves color 1 away from base (lib/rgb_matrix/animation/solid_reactive.ex#L89)
TODO: configurable base color (lib/rgb_matrix/animation/solid_reactive.ex#L51)
TODO: take speed into account (lib/rgb_matrix/animation/solid_reactive.ex#L76)
TODO: we can optimize this by rewriting the above instead of filtering here (lib/rgb_matrix/animation/solid_reactive.ex#L90)

SolidColor has a TODO:

TODO: configurable base color (lib/rgb_matrix/animation/solid_color.ex#L23)

Breathing:

TODO: configurable base color (lib/rgb_matrix/animation/breathing.ex#L25)

HueWave:

TODO: fixme (lib/rgb_matrix/animation/hue_wave.ex#L62)

The text was updated successfully, but these errors were encountered:

vanvoljg added the refactor label

vanvoljg changed the title ~~Refactor RGBMatrix.Animations.SolidReactive~~ Refactor RGBMatrix.Animation submodules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment