Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: transporter.verify(...).then is not a function was not fixed in 2.0.0 #1172

Closed
alwyn974 opened this issue Apr 28, 2024 · 3 comments
Closed

Comments

@alwyn974
Copy link

Describe the bug

transporter.verify(...).then is not a function TypeError: transporter.verify(...).then is not a function

As stated in the release changelog this bug was fixed in #1153
But in npm the code doesn't match the release https://www.npmjs.com/package/@nestjs-modules/mailer?activeTab=code
The fix is present in the tagged release

Promise.resolve(transporter.verify())

verifyTransporter(transporter, name) {
        const transporterName = name ? ` '${name}'` : '';
        transporter.verify()
            .then(() => this.mailerLogger.error(`Transporter${transporterName} is ready`))
            .catch((error) => this.mailerLogger.error(`Error occurred while verifying the transporter${transporterName}}: ${error.message}`));
    }
@juandav
Copy link
Member

juandav commented Apr 28, 2024

I'm working on some improvements and fixes that I've found, and I'm also transitioning the project to use TurboRepo so it can be tested more effectively.

@juandav
Copy link
Member

juandav commented Apr 28, 2024

#1173 Refactor

@alwyn974
Copy link
Author

Fixed with 2.0.1 release https://www.npmjs.com/package/@nestjs-modules/mailer/v/2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants