Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-informative message if packages are missing #22

Open
GegznaV opened this issue Feb 1, 2020 · 2 comments
Open

Non-informative message if packages are missing #22

GegznaV opened this issue Feb 1, 2020 · 2 comments

Comments

@GegznaV
Copy link
Contributor

GegznaV commented Feb 1, 2020

Non-informative message/output if both 'hunspell' and 'LanguageToolR' are missing.

> wellspell.addin:::gramcheck()

Listening on http://127.0.0.1:7446
Warning: Error in if: argument is of length zero
  81: observeEventHandler [D:/r/wellspell.addin/R/wellspell_config.R#245]
  10: shiny::runApp
   9: shiny::runGadget
   8: set_config [D:/r/wellspell.addin/R/wellspell_config.R#265]
   7: check [D:/r/wellspell.addin/R/wellspell.R#100]
   1: wellspell.addin:::gramcheck [D:/r/wellspell.addin/R/wellspell.R#7]
nevrome added a commit that referenced this issue Feb 9, 2020
@nevrome
Copy link
Owner

nevrome commented Feb 9, 2020

Please check if 2d9db4a fixes this, @GegznaV

@GegznaV
Copy link
Contributor Author

GegznaV commented Feb 12, 2020

Option 1: Packages are missing

If 'hunspell' or 'LanguageToolR' are missing, then wellspell.addin:::gramcheck() and wellspell.addin:::gramcheck() give informative messages, but wellspell.addin:::set_config() still opens the configuration dialogue and if "Done" button is pressed, the output is uninformative:


Listening on http://127.0.0.1:5002
Warning: Error in if: argument is of length zero
  76: observeEventHandler
   5: shiny::runApp
   4: shiny::runGadget
   1: wellspell.addin:::set_config

Option 2: 'LanguageToolR' is installed but the 'LanguageTool' is missing

If 'LanguageToolR' is installed but not configured, wellspell.addin:::gramcheck() open the configuration dialogue, and if "Done" is pressed, the output message is similar as in option 1:

> wellspell.addin:::gramcheck()

Listening on http://127.0.0.1:7691
Warning: Error in if: argument is of length zero
  83: observeEventHandler
  12: shiny::runApp
  11: shiny::runGadget
   8: set_config
   7: check
   1: wellspell.addin:::gramcheck

I think, in this situation, it should be suggested to run LanguageToolR::lato_quick_setup().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants