Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace emojipicker #2735

Open
1 task
mahibi opened this issue Feb 2, 2023 · 8 comments · May be fixed by #3439
Open
1 task

replace emojipicker #2735

mahibi opened this issue Feb 2, 2023 · 8 comments · May be fixed by #3439
Assignees
@Smarshal21
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request

Comments

@mahibi
Copy link
Collaborator

mahibi commented Feb 2, 2023

Android now offers an Emojipicker (currently alpha):
https://developer.android.com/jetpack/androidx/releases/emoji2#emojipicker-1.0.0-alpha01

As we have some problems with
https://github.com/vanniktech/Emoji

the picker might be replaced.

  • wait for stable release & try out
@mahibi mahibi added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) labels Feb 2, 2023
@mahibi mahibi mentioned this issue Mar 28, 2023
Open
@ghost
Copy link

ghost commented Apr 12, 2023

Looks like Stable version is now out https://developer.android.com/jetpack/androidx/releases/emoji2#1.3.0

@mahibi
Copy link
Collaborator Author

mahibi commented Apr 17, 2023

As far as i see the emojipicker will only be included since v1.4.0 which is still beta:
https://developer.android.com/jetpack/androidx/releases/emoji2#1.4.0-beta01

@ghost
Copy link

ghost commented Apr 17, 2023

Ahh okay sorry I thought it was also on version 1.3.0

@mahibi mahibi mentioned this issue Apr 21, 2023
Open
@Smarshal21
Copy link
Member

i want to work on this could you please assign this to me

@mahibi
Copy link
Collaborator Author

mahibi commented Aug 25, 2023

i want to work on this could you please assign this to me

the emojipicker from google is still in alpha state. Usually we avoid using alpha state libs so i suggest to wait a bit longer.

@Smarshal21
Copy link
Member

Smarshal21 commented Aug 25, 2023 via email

@mahibi mahibi mentioned this issue Aug 28, 2023
Closed
@mahibi
Copy link
Collaborator Author

mahibi commented Sep 27, 2023

It seems that emojipicker was released with emoji2 v1.4.0

https://developer.android.com/jetpack/androidx/releases/emoji2#version_14_2
https://developer.android.com/develop/ui/views/text-and-emoji/emoji-picker

If you are still interested, feel free to give it a try @Smarshal21

@Smarshal21 Smarshal21 self-assigned this Oct 27, 2023
@Smarshal21
Copy link
Member

i implemented it here - #3439

@AndyScherzinger AndyScherzinger linked a pull request Nov 8, 2023 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Smarshal21 Smarshal21

Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented Google EmojiPicker nextcloud/talk-android
2 participants
@mahibi @Smarshal21