Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message input field disappeared when joining open conversation #4454

Open
mahibi opened this issue Nov 15, 2024 · 3 comments · May be fixed by #4567
Open

Message input field disappeared when joining open conversation #4454

mahibi opened this issue Nov 15, 2024 · 3 comments · May be fixed by #4567
Assignees
@rapterjet2004
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request
Milestone
20.1.1

Comments

@mahibi
Copy link
Collaborator

mahibi commented Nov 15, 2024 •
edited
Loading

From @maximelehericy :

When joining a new conversation there is no chat bar, i need to press back and enter the room again so the chat bar appears and i can post messages

v20.0.2
@mahibi mahibi added 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request labels Nov 15, 2024
@mahibi mahibi added this to the 20.0.5 milestone Nov 15, 2024
@mahibi
Copy link
Collaborator Author

mahibi commented Nov 15, 2024 •
edited
Loading

maybe it could be related to #4439 where conversation was null.. don't think so
but maybe somehow caused by #4448 ??

@mahibi mahibi changed the title Message input field disappeared Message input field disappeared when joining open conversation Nov 26, 2024
@mahibi
Copy link
Collaborator Author

mahibi commented Nov 26, 2024

just understood that is is about when joining open conversations. So i now i can reproduce..

@mahibi mahibi modified the milestones: 20.0.5, 20.1.0 Nov 28, 2024
@AndyScherzinger AndyScherzinger modified the milestones: 20.1.0, 20.1.1 Dec 3, 2024
@rapterjet2004
Copy link
Contributor

rapterjet2004 commented Dec 12, 2024 •
edited
Loading

A bit tricky, since it seems the fragment is being committed, yet nothing shows up.

supportFragmentManager.commit {
    setReorderingAllowed(true) // optimizes out redundant replace operations
    replace(R.id.fragment_container_activity_chat, messageInputFragment)
    runOnCommit {
        Log.d(TAG, "Committed MessageInputFragment Successfully") // runs after transaction, gets called with no error
    }
}

@rapterjet2004 rapterjet2004 linked a pull request Dec 23, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rapterjet2004 rapterjet2004

Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request
Projects
None yet
Milestone
20.1.1
Development

Successfully merging a pull request may close this issue.

Fixed bug that hides message input upon joining open conversations nextcloud/talk-android
3 participants
@AndyScherzinger @mahibi @rapterjet2004