Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .php-ini and .php-version to expected files #575

Open
JohnRDOrazio opened this issue Jul 27, 2024 · 2 comments
Open

add .php-ini and .php-version to expected files #575

JohnRDOrazio opened this issue Jul 27, 2024 · 2 comments
Labels
enhancement feature: expected files Step 1 hotspot: local changes Temporary to sort these (htaccess, user.ini)

Comments

@JohnRDOrazio
Copy link

Even though the two files .php-ini and .php-version are not directly provided by nextcloud, they are however provided by my Plesk setup. It get's a bit annoying to have to move them out of the nextcloud folder in order to do the update, and then move them back in again after. I can't see any counter-indication to including them in the "expected" list?

updater/index.php

Lines 247 to 297 in 3b634b9

private function getExpectedElementsList(): array {
$expected = [
// Generic
'.',
'..',
// Folders
'.reuse',
'.well-known',
'3rdparty',
'apps',
'config',
'core',
'data',
'dist',
'l10n',
'lib',
'LICENSES',
'ocs',
'ocs-provider',
'ocm-provider',
'resources',
'settings',
'themes',
'updater',
// Files
'.rnd',
'index.html',
'indie.json',
'.user.ini',
'composer.json',
'composer.lock',
'console.php',
'cron.php',
'index.php',
'package.json',
'package-lock.json',
'public.php',
'remote.php',
'status.php',
'version.php',
'robots.txt',
'.htaccess',
'AUTHORS',
'CHANGELOG.md',
'COPYING',
'COPYING-AGPL',
'occ',
'db_structure.xml',
];
return array_merge($expected, $this->getAppDirectories());
}

May I create a PR that addresses this?

@JohnRDOrazio
Copy link
Author

I tested adding the two mentioned files to the expected files, and the builtin update went smoothly. Perhaps the related PR could be considered?

@joshtrichards
Copy link
Member

Given these are atypical filenames, maybe #372 makes more sense. Though I'm hesitant to make it so easy to ignore non-distributed files being in the installation folder, since it can lead to weird problems.

@joshtrichards joshtrichards added the hotspot: local changes Temporary to sort these (htaccess, user.ini) label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature: expected files Step 1 hotspot: local changes Temporary to sort these (htaccess, user.ini)
Projects
None yet
Development

No branches or pull requests

2 participants