Fetch app updates prior to starting Nextcloud upgrade

[blizzz]

To combat issues like nextcloud/server#47602 we should also fetch necessary app archives around downloading the nextcloud release.

A brainstorming with @nickvergessen brought up these ideas:

• Have a step to download app archives around download the nextcloud server archive
• To do so it is necessary to query the running instance to get the enabled apps
• Allow to specify apps that shall be ignored per parameter Report, but otherwise ignore apps that are not available on appstore
• When appstore is unavailable or an app download failed report and:
  • ask whether to continue in interactive mode
  • In non-interactive mode fail,
  • continue when --force is specified.
• app folder need to be read from config.php, if something is specified then i the first writable location shall be used. Placing them there is only possible after replacing code. Easier (for now?) is to add them just to the apps directory

[blizzz]

cc @Altahrim

[joshtrichards]

Related: #401 & #456

To do so it is necessary to query the running instance to get the enabled apps

The Updater itself technically doesn't handle upgrading of the apps, have db access, nor have access to any of our usual APIs. We should probably handle all this prior to even invoking Updater let alone occ upgrade.

We do have a convenient spot before Updater: the updatenotification app, which already checks apps that need updating and compatibility. We could also pre-download apps there (or follow the same approach anyway, by handling all this before the Updater is even invoked).

app folder need to be read from config.php, if something is specified then i the first writable location shall be used. Placing them there is only possible after replacing code. Easier (for now?) is to add them just to the apps directory

Not quite following the context for this one. Are you talking about where to drop the Archive files for the new pre-downloaded apps?

[blizzz]

To do so it is necessary to query the running instance to get the enabled apps

The Updater itself technically doesn't handle upgrading of the apps, have db access, nor have access to any of our usual APIs. We should probably handle all this prior to even invoking Updater let alone occ upgrade.

Yes, that is true, but it is already download the server code, so downloading relevant apps is not so far off either.

The issue with loading them before invoking the updater has the issue that the apps have to be put somewhere, and not replace current apps (they might not be compatible). There would be ways around this too, though.

We do have a convenient spot before Updater: the updatenotification app, which already checks apps that need updating and compatibility. We could also pre-download apps there (or follow the same approach anyway, by handling all this before the Updater is even invoked).

For the updatenotification can also be disabled, so we cannot exclusively rely on it.

app folder need to be read from config.php, if something is specified then i the first writable location shall be used. Placing them there is only possible after replacing code. Easier (for now?) is to add them just to the apps directory

Not quite following the context for this one. Are you talking about where to drop the Archive files for the new pre-downloaded apps?

Yes, they have to be put in place after replacing the nextcloud server code.

[joshtrichards]

Related: nextcloud/server#33561