Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLOT_CONSENSUS_PEAKS worflow does not produce the upset plot #248

Open
Alessandro201 opened this issue Jul 24, 2024 · 3 comments
Open

PLOT_CONSENSUS_PEAKS worflow does not produce the upset plot #248

Alessandro201 opened this issue Jul 24, 2024 · 3 comments
Labels
bug Something isn't working WIP Work in progress

Comments

@Alessandro201
Copy link

Description of the bug

Hello,

The workflow NFCORE_CUTANDRUN:CUTANDRUN:PEAK_QC:PLOT_CONSENSUS_PEAKS is run with 0 exit code, however, while the folder ${params.outdir}/04_reporting/consensus_upset_plots is created, the upset plots are not produced.

Here is the working directory of the workflow:

{workDir}/work/f5/f4[...]/
├── .command.begin
├── .command.err
├── .command.log
├── .command.out
├── .command.run
├── .command.sh
├── .command.trace
├── .exitcode
├── {GROUP 1}.macs2.consensus.peak_counts.bed -> {workDir}/work/f1/2eea337cf57ff46f6b3b77d9fb8265/{GROUP 1}.macs2.consensus.peak_counts.bed
├── {GROUP 2}.macs2.consensus.peak_counts.bed -> {workDir}/work/ed/19a8a14d34c607dcdaedd4153f8176/{GROUP 2}.macs2.consensus.peak_counts.bed
└── versions.yml

And here is .command.sh:

#!/bin/bash -euo pipefail
plot_consensus_peaks.py \
    --peaks "*.peaks.bed" \
    --outpath .

cat <<-END_VERSIONS > versions.yml
"NFCORE_CUTANDRUN:CUTANDRUN:PEAK_QC:PLOT_CONSENSUS_PEAKS":
    python: $(python --version | grep -E -o "([0-9]{1,}\.)+[0-9]{1,}")
    numpy: $(python -c 'import numpy; print(numpy.__version__)')
    pandas: $(python -c 'import pandas; print(pandas.__version__)')
    upsetplot: $(python -c 'import upsetplot; print(upsetplot.__version__)')
END_VERSIONS

After modifying the script: section in modules/local/python/plot_consensus_peaks.nf to:

plot_consensus_peaks.py \
    --peaks "*.peak_counts.bed" \
    --outpath .

cat <<-END_VERSIONS > versions.yml
"NFCORE_CUTANDRUN:CUTANDRUN:PEAK_QC:PLOT_CONSENSUS_PEAKS":
    python: $(python --version | grep -E -o "([0-9]{1,}\.)+[0-9]{1,}")
    numpy: $(python -c 'import numpy; print(numpy.__version__)')
    pandas: $(python -c 'import pandas; print(pandas.__version__)')
    upsetplot: $(python -c 'import upsetplot; print(upsetplot.__version__)')
END_VERSIONS

it works as expected.

Command used and terminal output

nextflow run nf-core/cutandrun -profile singularity -params-file params.yaml --input samplesheet.csv


params.yaml

input: "./samplesheet.csv"
outdir: "./results"
genome: "GRCh38"
peakcaller: "MACS2,SEACR"
dt_calc_all_matrix: true
use_control: false
skip_igv: true


### Relevant files

_No response_

### System information

Nextflow: 24.04.3.5916
Hardware: HPC
Executor: PBS
Container engine: Singularity
OS: Rocky Linux 8.10 kernel 4.18.0
Architecture: x86-64
nf-core/cutandrun: tested with both 3.2.2 and master
@Alessandro201 Alessandro201 added the bug Something isn't working label Jul 24, 2024
Alessandro201 added a commit to Alessandro201/cutandrun that referenced this issue Jul 24, 2024
@Alessandro201 Alessandro201 mentioned this issue Jul 24, 2024
11 tasks
@chris-cheshire
Copy link
Contributor

Thanks for the fix!

@chris-cheshire chris-cheshire added the WIP Work in progress label Aug 29, 2024
@AprilJack
Copy link

I am having the same issue using release 3.2.2.

@Taratype0
Copy link

Hi there, I've been running into an issue with release v3.2.2-g6e1125d, similar to what others have experienced. Does anyone know if there's a way to tweak the script on the server side to fix this problem? Any guidance would be greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WIP Work in progress
Projects
None yet
Development

No branches or pull requests

4 participants